I recently modified a test manifest (toml) file and ran ./mach lint --outgoing --fix and was surprised to see that it moved code around of changes unrelated to my patch.

It turns out that in this particular example, a recently added entry was not in alphabetical order: test_ModelHubProvider.js is placed between lowercase test_* instead of uppercase test_* at https://searchfox.org/mozilla-central/rev/03f39c99dc11e3f0c51cfb61b5f84cad988326d0/toolkit/mozapps/extensions/test/xpcshell/xpcshell.toml#151-155

I'm going to attach a patch that runs ./mach lint --fix on several test manifests (toml files).

... to preserve alphabetical order, so that we don't have to make an
exception in the toml linter.

This diff was generated as follows:

List all toml files in the tree:

find * -name '*.toml' > /tmp/toml

Manually edited /tmp/toml to drop non-relevant entries (objdir).

Ran the toml linter for all files:

cat /tmp/toml | xargs ./mach lint -l test-manifest-toml --fix

Mark, do you know why the test-manifest-toml linter did not trigger a warning in the patch to bug 1944689? It introduced the change that prompted me to look at the linter failure: https://phabricator.services.mozilla.com/D236448#change-YkF6uUWOgcWd

https://hg.mozilla.org/mozilla-central/rev/ae3c1f7be518
https://hg.mozilla.org/mozilla-central/rev/09d742fa8bb4

(In reply to Rob Wu [:robwu] from comment #4)

Mark, do you know why the test-manifest-toml linter did not trigger a warning in the patch to bug 1944689? It introduced the change that prompted me to look at the linter failure: https://phabricator.services.mozilla.com/D236448#change-YkF6uUWOgcWd

As far as I know it should work - I've seen it work for ESLint in the past. I've just filed the issue here.

https://hg.mozilla.org/mozilla-central/rev/0aed0882ecfc